Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct namespace imports for golem 0.4.0 #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ColinFay
Copy link

@ColinFay ColinFay commented Feb 3, 2023

The upcoming version of {golem} will have functions that override the {pkgload} functions.

This creates a namespace conflict with your package :

> devtools::document()
ℹ Updating MainExistingDatasets documentation
Setting `RoxygenNote` to "7.2.3"
ℹ Loading MainExistingDatasets
Writing NAMESPACE
Warning messages:
1: replacing previous import ‘golem::pkg_version’ by ‘pkgload::pkg_version’ when loading ‘MainExistingDatasets’ 
2: replacing previous import ‘golem::pkg_name’ by ‘pkgload::pkg_name’ when loading ‘MainExistingDatasets’ 
3: replacing previous import ‘golem::pkg_path’ by ‘pkgload::pkg_path’ when loading ‘MainExistingDatasets’ 

This PR addresses this issue by preventing the import of these three functions from {pkgload}.

This will fix the issue with 
golem 0.4.0
@ColinFay
Copy link
Author

@baptisteCD The new golem version is on its way to CRAN.

you might receive a message from the CRAN team in a few, so you might want to accept this PR soon :)

let me know if i can help you in any way

Cheers,
Colin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant