Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix build - RE_VA_ARGS compatibility #66

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

cspiel1
Copy link
Collaborator

@cspiel1 cspiel1 commented Feb 6, 2025

includes missed updates of CMakeLists.txt from baresip repo

@cspiel1
Copy link
Collaborator Author

cspiel1 commented Feb 6, 2025

Not clear for me why the clang tests fail. I'll check the differences in CMakeLists.txt.

@sreimers
Copy link
Member

sreimers commented Feb 6, 2025

For clang these flags are needed:

  if(CMAKE_C_COMPILER_ID MATCHES "Clang")
    list(APPEND c_flags
      -Watomic-implicit-seq-cst
      -Wshorten-64-to-32
      -Wno-gnu-zero-variadic-macro-arguments
      -Wno-c2x-extensions
    )
  endif()

@cspiel1
Copy link
Collaborator Author

cspiel1 commented Feb 6, 2025

And, should I add _GNU_SOURCE to RE_DEFINITIONS?

baresip commits:
- a3a38d348efcda4ba1894f60e449f9356753cdf5
- 21602671df2f8aeec2561720e4aa06c6dbded9c5
@cspiel1
Copy link
Collaborator Author

cspiel1 commented Feb 6, 2025

@sreimers please could you review and merge?

edit: On my dev host could reproduce the clang build failure without the last 4 commits. Now it builds.

@sreimers sreimers merged commit 40c0f4d into baresip:main Feb 6, 2025
6 checks passed
@cspiel1
Copy link
Collaborator Author

cspiel1 commented Feb 6, 2025

thanks!

@cspiel1 cspiel1 deleted the cmake_fix_build_RE_VA_ARGS_logging branch February 6, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants