Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: remove long async blocking #43

Merged
merged 3 commits into from
Nov 13, 2020
Merged

main: remove long async blocking #43

merged 3 commits into from
Nov 13, 2020

Conversation

alfredh
Copy link
Contributor

@alfredh alfredh commented Nov 12, 2020

No description provided.

@alfredh
Copy link
Contributor Author

alfredh commented Nov 12, 2020

@sreimers or @juha-h if you agree, please merge to master.

@sreimers
Copy link
Member

Sometimes a long async blocking hint is useful for debugging. Maybe make it depend to #if (DEBUG_LEVEL >= 7) instead of MAIN_DEBUG?

@juha-h
Copy link
Contributor

juha-h commented Nov 13, 2020 via email

@alfredh
Copy link
Contributor Author

alfredh commented Nov 13, 2020

okay, I would like to suggest that this check is disabled by default.
it should only be enabled if explicitly compiled in, e.g. MAIN_DEBUG or DEBUG_LEVEL.

also, a threshold of 100ms seems a bit low. perhaps 500ms is better.

on embedded platforms, this warning comes up quite a lot due to slow CPU.

@juha-h
Copy link
Contributor

juha-h commented Nov 13, 2020 via email

@alfredh
Copy link
Contributor Author

alfredh commented Nov 13, 2020

please have a look at the last commit.

MAIN_DEBUG and TMR_DEBUG is off by default.

it can be enabled explicitly:

make EXTRA_CFLAGS=-DMAIN_DEBUG=1

@sreimers sreimers merged commit 783edd7 into master Nov 13, 2020
@sreimers sreimers deleted the long_async_blocking branch December 4, 2020 10:43
@sreimers sreimers added the removed Removed feature label Apr 9, 2021
@sreimers sreimers added this to the v2.0.0 milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removed Removed feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants