Fix tls statemachine during tls v1.2 renegotiation #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fAuernigg
changed the title
This was referenced Feb 27, 2023
alfredh
reviewed
Feb 28, 2023
src/tls/openssl/tls_tcp.c
Outdated
| && SSL_state(tc->ssl) != TLS_ST_CW_FINISHED | ||
| && SSL_state(tc->ssl) != TLS_ST_SW_SRVR_DONE | ||
| #endif | ||
| ) { |
There was a problem hiding this comment.
it is a bit difficult to read ...
perhaps it is better to declare a bool before the if and use that bool inside the if ?
fAuernigg
force-pushed
the
fix_tls_statemachine_during_tls_1_2_renegotiation
branch
2 times, most recently
from
5801dfb to
4e82824
Compare
|
thanks, this looks much better :) |
cspiel1
reviewed
Feb 28, 2023
src/tls/openssl/tls_tcp.c
Outdated
| @@ -217,6 +217,7 @@ static bool recv_handler(int *err, struct mbuf *mb, bool *estab, void *arg) | |||
| { | |||
| struct tls_conn *tc = arg; | |||
| int r; | |||
| bool reneg_state = false; | |||
There was a problem hiding this comment.
I would prefer reneg as name for this flag.
fAuernigg
force-pushed
the
fix_tls_statemachine_during_tls_1_2_renegotiation
branch
from
4e82824 to
a586547
Compare
fAuernigg
force-pushed
the
fix_tls_statemachine_during_tls_1_2_renegotiation
branch
from
a586547 to
4832ccc
Compare
|
Looks good to me. |
|
Are there any security risks by handling/accepting renegotiations?
Or is this unrelated? |
|
Maybe we could make it configurable for specific HTTP URL paths to allow TLS 1.2 renegotiation in a hopefully simple and readable way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.