list: refactor/optimize list_insert_sorted #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreimers
changed the title
sreimers
force-pushed
the
refactor_list_insert_sorted
branch
from
fa088b8 to
278c8e4
Compare
`list_insert_sorted()` can handle two cases, forward and reverse sort. So I think we can reduce complexity.
sreimers
force-pushed
the
refactor_list_insert_sorted
branch
from
26f73b5 to
8750d79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list_insert_sorted()can handle two cases, forward and reverse sort (on already sorted list).So I think we can reduce complexity.