main: fd_listen fhs alloc rewrite #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfredh
reviewed
May 16, 2023
alfredh
reviewed
Jul 1, 2023
alfredh
reviewed
Jul 8, 2023
sreimers
force-pushed
the
fhs_alloc
branch
3 times, most recently
from
dfe99a9 to
df5aeeb
Compare
|
@Lastique Can you review if this PR matches your use case? |
Lastique
reviewed
Sep 2, 2023
Lastique
reviewed
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an application uses multiple (maybe thousands) of libre event loop threads, the unused pre-allocated memory for fhs can be quite high. This PR uses a application allocated fhs with
fd_listen. This way EPOLL and KQUEUE have no hard fd limit anymore (re->maxfds limits only returned active event handlers per fd_poll). The fd limit for SELECT stays the same.Alternative approach with less overhead compared to #428