fmt: handy functions for pointer-length objects #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cHuberCoffee
force-pushed
the
pl_functions
branch
from
017836c to
1582053
Compare
alfredh
reviewed
Jul 24, 2023
src/fmt/pl.c
Outdated
| * | ||
| * @return 0 if success, otherwise errorcode | ||
| */ | ||
| int pl_hex(const struct pl *pl, uint8_t *hex, unsigned int len) |
There was a problem hiding this comment.
please use size_t instead of unsigned int
alfredh
reviewed
Jul 24, 2023
src/fmt/pl.c
Outdated
| */ | ||
| int pl_hex(const struct pl *pl, uint8_t *hex, unsigned int len) | ||
| { | ||
| unsigned int i; |
There was a problem hiding this comment.
using C99 style, this variable can be declared inside the for-loop.
Also please use size_t
alfredh
reviewed
Jul 24, 2023
src/fmt/pl.c
Outdated
| if (pl->l - i < str_len(str)) | ||
| return NULL; | ||
|
|
||
| if (!memcmp(pl->p + i, str, str_len(str))) |
There was a problem hiding this comment.
you can cache the length of the string, it should speed up the function slightly ...
sreimers
reviewed
Jul 25, 2023
src/fmt/pl.c
Outdated
| @@ -655,6 +678,39 @@ const char *pl_strrchr(const struct pl *pl, char c) | |||
| } | |||
|
|
|||
|
|
|||
| /** | |||
| * Locate the fist substring in a pointer-length string | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.