Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty isoform switching reports are not empty #34

Closed
fruce-ki opened this issue Sep 20, 2017 · 1 comment
Closed

Empty isoform switching reports are not empty #34

fruce-ki opened this issue Sep 20, 2017 · 1 comment
Assignees
Labels
bug RATs not behaving the way it is intended to.
Milestone

Comments

@fruce-ki
Copy link
Collaborator

fruce-ki commented Sep 20, 2017

The isoform switching summary has an off-by-one error when there are no results to report. The ID lists, instead of being empty vectors, contain a NA value. As a result, the tallies report values of 1 instead of 0. When there are results to report, the NAs and the off-by-one error do not apply.

This is likely a data.table subsetting error. When nothing matches the subset criteria, data.table returns a row of NA. I need to catch this.

A similar issue used to happen with the DTU summary, so that should serve as a template for the solution here too.

@fruce-ki fruce-ki added the bug RATs not behaving the way it is intended to. label Sep 20, 2017
@fruce-ki
Copy link
Collaborator Author

Actually the NA values are explicitly coded in case of no results, to ensure that the named fields are created and to prevent the return value from being an empty list or data.frame. Instead, this should have been achieved by assigning empty character vectors instead of NA values.

@fruce-ki fruce-ki self-assigned this Sep 20, 2017
fruce-ki added a commit that referenced this issue Sep 20, 2017
@fruce-ki fruce-ki added this to the 0.6.0 milestone Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug RATs not behaving the way it is intended to.
Projects
None yet
Development

No branches or pull requests

1 participant