Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo improvement #1503

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

typo improvement #1503

wants to merge 8 commits into from

Conversation

prestoalvarez
Copy link
Contributor

Corrected synpase to synapse
Corrected "Lyvely " to "Lyvely"

@vercel Vercel
Copy link

vercel bot commented Dec 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:32am

@vercel Vercel
Copy link

vercel bot commented Dec 29, 2024

@prestoalvarez is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 29, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

wbnns
wbnns requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prestoalvarez

Thanks for this PR; left a comment in-line with a small change

@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related labels Dec 30, 2024
@prestoalvarez
Copy link
Contributor Author

@wbnns corrected!

@prestoalvarez prestoalvarez requested a review from wbnns January 8, 2025 13:30
wbnns
wbnns approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prestoalvarez Thanks for contributing and for building on Base 🔵

@wbnns wbnns added ready for merge Ready for merge, an additional reviewer is needed and removed change(s) requested One or more changes have been requested labels Jan 15, 2025
@wbnns wbnns enabled auto-merge (squash) January 15, 2025 01:45
@wbnns
Copy link
Member

wbnns commented Jan 15, 2025 •
edited
Loading

@prestoalvarez This can't be merged unless all of your commits are signed
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

You may need to do a full rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughescoin hughescoin hughescoin approved these changes

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
base ecosystem review This is ecosystem related ready for merge Ready for merge, an additional reviewer is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@prestoalvarez @cb-heimdall @wbnns @hughescoin @maradini77 @donatik27 @L1QU2D