Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Document clarity, fix typos, and enhance formatting #1520

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

Bitcex
Copy link
Contributor

@Bitcex Bitcex commented Jan 1, 2025

it fixes

  1. Typo and corrected minor grammatical errors
  2. Clarity of documentation and contributing guidelines

it fixes
1. Typo and corrected minor grammatical errors
2. Clarity of documentation and contributing guidelines
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 1, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Jan 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 5:01pm

Copy link

vercel bot commented Jan 1, 2025

@Bitcex is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bitcex

Thanks for contributing and for building on Base 🔵

@wbnns wbnns added the base docs review To be reviewed by the Base docs team label Jan 9, 2025
@wbnns
Copy link
Member

wbnns commented Jan 9, 2025

@Bitcex

Could you please rebase and fix the merge conflict?

@Bitcex
Copy link
Contributor Author

Bitcex commented Jan 9, 2025

@wbnns conflicts have been resolved

@wbnns wbnns enabled auto-merge (squash) January 15, 2025 01:04
@wbnns wbnns merged commit 0203575 into base-org:master Jan 15, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base docs review To be reviewed by the Base docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants