Merge latest changes into 2.0 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change nodetool so that functions of zero arity may be called using the supplied rpc facility. This is done by making a distinction between the case when rpc parameters are present and when they are not. Previously calling zero arity functions has not been possible because even submitting no rpc parameters is treated the same as submitting the request with a single parameter of an empty list. Nodetool encapsulates any parameters as a list and the result of attempting to call a function that takes no parameters was the rpc function calling the supplied function with a single parameter of an empty list. This change does not preclude calling functions with a single parameter of an empty list. It just now makes that decision explicit on the part of the caller.
Revert "Merge branch 'feature/nodetool-zero-arg-rpc' into develop"
Merge 2.0 branch into develop
Review submitted PR [JIRA: TOOLS-138]
Review submitted PR [JIRA: TOOLS-139]
Replacing whoami with id -un to be more POSIX.2 compliant [JIRA: TOOLS-143]
Properly Escape Arguments to Runner
|
Cutting a fresh 2.x tag |
gcymbalski
added a commit
that referenced
this pull request
Dec 7, 2015
Merge latest changes into 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.