fix(update): fix createSort import by external use

- remove last `LoadingSpinner`
basics · Jun 12, 2023 · afa335d · afa335d
1 parent bd4b1c0
commit afa335d
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 55 deletions.
diff --git a/src/module.mjs b/src/module.mjs
@@ -47,6 +47,10 @@ export default defineNuxtModule({
     nuxt.options.alias['#speedkit'] = runtimeDir;
     nuxt.options.build.transpile.push(runtimeDir);
 
+    // Workaround for missing default function by external use.
+    nuxt.options.alias['speedkit-create-sort'] =
+      'sort-css-media-queries/lib/create-sort.js';
+
     if (!moduleOptions.disableNuxtImage) {
       moduleOptions.targetFormats =
         moduleOptions.targetFormats || DEFAULT_TARGET_FORMATS;

diff --git a/src/runtime/components/SpeedkitIframe.vue b/src/runtime/components/SpeedkitIframe.vue
@@ -9,7 +9,7 @@
 </template>
 
 <script setup>
-import { defineProps, defineEmits, ref, watch } from 'vue';
+import { ref, watch } from 'vue';
 import useComponentObserver from '#speedkit/composables/componentObserver';
 
 const props = defineProps({

diff --git a/src/runtime/components/SpeedkitImage/Base.vue b/src/runtime/components/SpeedkitImage/Base.vue
@@ -16,11 +16,6 @@
 </template>
 
 <script>
-/**
- * TODO: LoadingSpinner
- * suspense?
- */
-
 import { crossorigin as validatorCrossorigin } from '../../utils/validators.mjs';
 import { getImageStyleDescription } from '#speedkit/utils/description.mjs';
 import { getCrossorigin } from '#speedkit/utils';

diff --git a/src/runtime/components/SpeedkitImage/classes/LoadingSpinner.js b/src/runtime/components/SpeedkitImage/classes/LoadingSpinner.js
diff --git a/...omponents/SpeedkitImage/classes/Source.js → ...mponents/SpeedkitImage/classes/Source.mjs b/...omponents/SpeedkitImage/classes/Source.js → ...mponents/SpeedkitImage/classes/Source.mjs
diff --git a/...e/components/SpeedkitImage/utils/image.js → .../components/SpeedkitImage/utils/image.mjs b/...e/components/SpeedkitImage/utils/image.js → .../components/SpeedkitImage/utils/image.mjs
diff --git a/src/runtime/components/SpeedkitPicture/Base.vue b/src/runtime/components/SpeedkitPicture/Base.vue
@@ -9,7 +9,6 @@
       :class="classNames.image"
       :title="title"
       :alt="alt"
-      :loading-spinner="loadingSpinner"
       :crossorigin="crossorigin"
       width="0"
       height="0"
@@ -23,7 +22,6 @@ import { crossorigin as validatorCrossorigin } from '../../utils/validators.mjs'
 import useCritical from '#speedkit/composables/critical';
 import BaseImage from '#speedkit/components/SpeedkitImage/Base';
 import SourceList from '#speedkit/components/SpeedkitPicture/classes/SourceList';
-import LoadingSpinner from '#speedkit/components/SpeedkitImage/classes/LoadingSpinner';
 import PictureSource from '#speedkit/components/SpeedkitPicture/Source';
 
 import { useImage, useHead, useNuxtApp } from '#imports';
@@ -49,11 +47,6 @@ export default {
       }
     },
 
-    loadingSpinner: {
-      type: LoadingSpinner,
-      default: undefined
-    },
-
     title: {
       type: String,
       default: null

diff --git a/...nts/SpeedkitPicture/classes/SourceList.js → ...ts/SpeedkitPicture/classes/SourceList.mjs b/...nts/SpeedkitPicture/classes/SourceList.js → ...ts/SpeedkitPicture/classes/SourceList.mjs
@@ -1,4 +1,5 @@
-import createSort from 'sort-css-media-queries/lib/create-sort';
+import createSort from 'speedkit-create-sort';
+
 import Source from '../../SpeedkitImage/classes/Source';
 import { toHashHex } from '#speedkit/utils/string';