Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Scheduler arguments to be callables for delayed resource determination #229

Merged
merged 28 commits into from
Jul 18, 2024

Conversation

basnijholt
Copy link
Owner

@basnijholt basnijholt commented Jun 19, 2024

This is useful when using dependencies and new job's resources should be set dependent on the job.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 90.65421% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.59%. Comparing base (97b20d8) to head (d682d94).
Report is 10 commits behind head on main.

Files Patch % Lines
adaptive_scheduler/_scheduler/slurm.py 90.58% 8 Missing ⚠️
adaptive_scheduler/_server_support/slurm_run.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   74.72%   74.59%   -0.13%     
==========================================
  Files          22       22              
  Lines        2777     2850      +73     
==========================================
+ Hits         2075     2126      +51     
- Misses        702      724      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@basnijholt basnijholt merged commit f28d467 into main Jul 18, 2024
9 of 10 checks passed
@basnijholt basnijholt deleted the callable-scheduler-args branch July 18, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant