Fix RestartStrategy::timeout < 1s

[nicolaiunrein]

Fix issue where fractions of a second are ignored internally. This leads to a broken RestartStrategy when given a timeout of eg. Duration::from_millis(999). NOTE: The type casting of multiplier can get removed but that would be a breaking change. I leave this for the reviewer to decide.

Checklist

• tests are passing with cargo test.
• tests and/or benchmarks are included
• commit message is clear

[o0Ignition0o]

Hey, thanks a lot for the pull request!

In our first implementation, we hadn't thought of a timeout < 1 sec, so that's a very welcome patch!

I'll leave it up to @Relrin to review the changes, because I think he's been working on it the most.

He might be able to decide whether we wanna make a breaking change (there's a lot of things happening on the executor side, so we might wanna bump both at the same time).

Thanks again!

[Relrin]

Hey, @nicolaiunrein

In general, it looks good. However, before merging this patch, we will need a couple of more changes:

• Changing the type of multiplier / restart_count fields to the u32 type
• https://github.com/bastion-rs/bastion/pull/265/files#diff-ac7c8b5d6ded424471b6bab833e5fee9R1897-R1898 - Apply the same calculation way, but with fixed field types for the LinearBackOff strategy

He might be able to decide whether we wanna make a breaking change (there's a lot of things happening on the executor side, so we might wanna bump both at the same time).

I think it will be competely fine to deliver a new version with a couple of "breaking changes" in the single release. Plus, there's no significant impact on existing users because most of the users not going for exceed u32 limits in real applications.

And yeah, thanks ahead for the patch!

[Relrin]

Changing the multiplier / restarts_count field types in the RestartStrategy structure to the u32 type will eliminate type converstions.

[nicolaiunrein]

I realized that after all f64 might actually be what we want for multiplier because with an integer we are not able to increase the delay by eg. 10% on each try. The downside is that this will generate more changes:

1. users need to change eg. 1 -> 1.0
2. need to remove impl of Eq for ActorRestartStrategy and RestartStrategy

So feel free to undo the last commit.

[Relrin]

I realized that after all f64 might actually be what we want for multiplier because with an integer we are not able to increase the delay by eg. 10% on each try. The downside is that this will generate more changes:

1. users need to change eg. 1 -> 1.0
2. need to remove impl of Eq for ActorRestartStrategy and RestartStrategy

In practice this is a quite rare case, and for the most users is more than enough to have a delay calculated with integer values. So, I think it's reasonable to left it as it for now :)

[o0Ignition0o]

I think we're a cargo fmt away from merging it ! 🎉

[nicolaiunrein]

Do you want me to revert to u32?

[Relrin]

Yes, please, revert it back to the u32 type

[o0Ignition0o]

Amazing, thanks a lot for your contribution! 🎉