Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip, allow to run tokio based futures in the bastion executor #299

Merged
merged 14 commits into from
Feb 1, 2021
Merged

wip, allow to run tokio based futures in the bastion executor #299

merged 14 commits into from
Feb 1, 2021

Conversation

o0Ignition0o
Copy link
Contributor

Checklist
  • tests are passing with cargo test.
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message is clear

@o0Ignition0o
Copy link
Contributor Author

This is prolly close to a reviewable state 🙏

@o0Ignition0o o0Ignition0o marked this pull request as ready for review January 31, 2021 20:36
@o0Ignition0o o0Ignition0o requested review from vertexclique and Relrin and removed request for vertexclique February 1, 2021 09:02
Relrin
Relrin approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@Relrin Relrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@o0Ignition0o o0Ignition0o merged commit 39ff2b8 into master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Relrin Relrin Relrin approved these changes

@vertexclique vertexclique Awaiting requested review from vertexclique

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o0Ignition0o @Relrin