Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InitFromSamples under transformations #461

Closed
wants to merge 2 commits into from
Closed

Fix InitFromSamples under transformations #461

wants to merge 2 commits into from

Conversation

oschulz
Copy link
Member

@oschulz oschulz commented Nov 11, 2024

This works properly now:

using BAT

posterior = BAT.example_posterior()
smpls = bat_sample(posterior, MCMCSampling()).result

new_smpls = bat_sample(
    posterior,
    MCMCSampling(
        init = MCMCChainPoolInit(
            initval_alg = InitFromSamples(smpls)
        )
    )
).result

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.79%. Comparing base (6022828) to head (507638a).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
src/initvals/initvals.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   47.38%   52.79%   +5.41%     
==========================================
  Files         112      124      +12     
  Lines        5422     6571    +1149     
==========================================
+ Hits         2569     3469     +900     
- Misses       2853     3102     +249     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz
Copy link
Member Author

oschulz commented Nov 12, 2024

Will be a patch release on the release branch.

@oschulz oschulz closed this Nov 12, 2024
@oschulz oschulz deleted the release-3 branch November 12, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants