Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybatfish: remove tests of deprecated API #871

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

dhalperi
Copy link
Member

that API is gone, after all.

that API is gone, after all.

commit-id:6b67a2a6
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #871 (abe6f6b) into master (5ee6d27) will decrease coverage by 1.40%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   87.51%   86.11%   -1.41%     
==========================================
  Files          30       30              
  Lines        3989     3989              
  Branches      645      645              
==========================================
- Hits         3491     3435      -56     
- Misses        351      406      +55     
- Partials      147      148       +1     
Impacted Files Coverage Δ
pybatfish/client/resthelper.py 47.72% <0.00%> (-27.28%) ⬇️
pybatfish/client/internal.py 70.83% <0.00%> (-12.50%) ⬇️
pybatfish/client/workhelper.py 65.76% <0.00%> (-10.87%) ⬇️
pybatfish/client/session.py 75.99% <0.00%> (-4.90%) ⬇️

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi merged commit 63a6297 into master Dec 29, 2022
@dhalperi dhalperi deleted the pr/dhalperi/master/6b67a2a6 branch December 29, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants