Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybatfish: explicit urllib3 lower bound #896

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Conversation

dhalperi
Copy link
Member

Fix #895

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #896 (f9a78ba) into master (c8e8a34) will not change coverage.
The diff coverage is n/a.

❗ Current head f9a78ba differs from pull request most recent head 25d9d9f. Consider uploading reports for the commit 25d9d9f to get more accurate results

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          30       30           
  Lines        3977     3977           
  Branches      664      664           
=======================================
  Hits         3420     3420           
  Misses        411      411           
  Partials      146      146           

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi merged commit 5a0488d into master Sep 23, 2023
@dhalperi dhalperi deleted the spr/master/2b6674f2 branch September 23, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urllib3 dependency version should be updated to use "allowed_methods" parameter
2 participants