Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: upgrade to artifacts v3->v4 #928

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Oct 8, 2024

Like #923 but with both sides or it doesn't work

Like #923 but with both sides or it doesn't work

commit-id:bb124889
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi enabled auto-merge (squash) October 8, 2024 20:02
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.11%. Comparing base (d86e1a1) to head (f69173f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files          24       24           
  Lines        3555     3555           
  Branches      718      718           
=======================================
  Hits         3097     3097           
  Misses        328      328           
  Partials      130      130           

@dhalperi dhalperi merged commit 3e4f85a into master Oct 8, 2024
17 checks passed
@dhalperi dhalperi deleted the spr/master/bb124889 branch October 8, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants