Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material-ui #2

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Update material-ui #2

merged 1 commit into from
Jul 19, 2021

Conversation

ShirasawaSama
Copy link
Contributor

@ShirasawaSama ShirasawaSama commented Jul 19, 2021

🤔 This is a ...

  • New feature
  • Bug fix
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • README update
  • Other (about what?)

🔗 Related issue link

#1

💡 Background and solution

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Demo in storybook is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • README API section is updated or not needed

Copy link
Owner

@baymac baymac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment above, everything looks good to me. I will find some time today to test these changes.

package.json Show resolved Hide resolved
Copy link
Owner

@baymac baymac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for your contribution.

@baymac baymac merged commit 1ba5cc6 into baymac:master Jul 19, 2021
@baymac
Copy link
Owner

baymac commented Jul 19, 2021

Just one suggestion, send pr from a separate branch instead of master else it gets difficult to pull the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants