-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/i18n #8
Conversation
@ShirasawaSama you might want to check this. Let me know if any improvements required. |
|
I think the current design is good. Thank you. But what do you think of the localization API based on https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/locale/index.ts#L3 |
|
@baymac If you don't think it's necessary, you don't need to change it. |
@ShirasawaSama I have added locale support for construe, but it is not working for me. Do you have any idea why? |
@baymac - import cronstrue from 'cronstrue'
+ import cronstrue from 'cronstrue/i18n' |
@ShirasawaSama thanks. Do you think now this pr is ready to be merged? |
@baymac yes |
🤔 This is a ...
🔗 Related issue link
#1
💡 Background and solution
Problem statement
Add Internalization support
Problem Solving
en
locale.localeState
value.Last Day of Month
selection.Scheduler
component to allow custom locale values or reusing an predefined locale in the library.☑️ Self Check before Merge