Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new listener to cookieConsent #118

Merged
merged 12 commits into from
Mar 16, 2022

Conversation

RahulSubramaniam17
Copy link
Collaborator

PR description

JIRA tickets

PD-177966
PD-177967

This PR is for

  • Feature

Requirements / issues

  • Cookie module should listen to the add consent event when it creates a cookie
  • Cookie consent module should have a function which passes the entire consent object to a callback whenever there is any change in the consent

Solutions

  • subscribed to the add event in the cookie module when creating a cookie
  • Exposed a new method called subscribeStore. Which accepts a callback function and passes the store object as the param ameter

Test cases summary

  • Existing test cases work

Steps to verify

  • Use the new module and run the subscribeStore command to test it out

@sonarqube-devops-platform
Copy link

@soumen-saniel soumen-saniel merged commit 35c7abd into bazaarvoice:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants