Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returning cloned promise for bvFetch module #138

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

VarshaAdigaBV
Copy link
Collaborator

PD-230727

Problem/Goal

Creating bvFetch module whose purpose is to cache duplicate api calls. Need to resolve error Error: TypeError: Already read

Solution

Created the module which caches the api responses based on the url.
Made change to return cloned promise to fix the error.

@VarshaAdigaBV VarshaAdigaBV changed the title returning cloned promise returning cloned promise for bvFetch module Mar 26, 2024
Copy link
Contributor

@soumen-saniel soumen-saniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved

@soumen-saniel soumen-saniel merged commit e57371b into bazaarvoice:master Mar 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants