Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csat pd 254370 bv fetch issue #144

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Csat pd 254370 bv fetch issue #144

merged 3 commits into from
Sep 25, 2024

Conversation

visheshsanghani
Copy link
Collaborator

PR description

JIRA tickets

PD-254370

This PR is for

  • Bug

Requirements / issues

  • Some clients have a feature that clears the cache on every reload. This action removes the bvFetch cache, and on the next reload, when the webpage tries to access the cache, the reviews container fails due to the cache no longer being available.

Solutions

  • The solution is to ensure that when the page attempts to access the cache and finds it does not exist, it is recommended to trigger the fetch call again to the API.

VarshaAdigaBV
VarshaAdigaBV approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@VarshaAdigaBV VarshaAdigaBV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Shubhakar-A
Shubhakar-A approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@Shubhakar-A Shubhakar-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@visheshsanghani visheshsanghani merged commit 0b35d8a into bazaarvoice:master-csat-pd-254370-bv-fetch-cache Sep 25, 2024
3 of 4 checks passed
visheshsanghani added a commit that referenced this pull request Dec 11, 2024
@visheshsanghani
Csat pd 254370 bv fetch issue (#144) (#145)
c3365b9 
* [PD-254370]: Bv fetch issue resolved

* Release 2.9.5

* Release 2.9.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shubhakar-A Shubhakar-A Shubhakar-A approved these changes

@VarshaAdigaBV VarshaAdigaBV VarshaAdigaBV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visheshsanghani @Shubhakar-A @VarshaAdigaBV