-
Notifications
You must be signed in to change notification settings - Fork 389
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gazelle_binary: remove mode attributes (#882)
This PR removes mode attributes (goos, goarch, race, etc.) from the gazelle_binary rule. These attributes were implemented using private files in rules_go, so supporting them is blocking changes in the rules_go implementation. These attributes should probably never be used. gazelle_binary should generally be built for the host configuration (by 'bazel run' or 'bazel build' without configuration flags). If a binary is still needed in a different configuration, that may still be accomplished with command-line flags like --platforms or --@io_bazel_rules_go//go/config:race. Fixes #803
- Loading branch information
Jay Conrod
authored
Aug 26, 2020
1 parent
866b963
commit 7033f2c
Showing
2 changed files
with
5 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters