Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename io_bazel_rules_go to rules_go? #990

Open
Vertexwahn opened this issue Dec 5, 2024 · 3 comments
Open

Rename io_bazel_rules_go to rules_go? #990

Vertexwahn opened this issue Dec 5, 2024 · 3 comments

Comments

@Vertexwahn
Copy link

Can we rename io_bazel_rules_go to rules_go? I have currently a project that uses rules_go and when using aspect_bazel_lib I have conflict. aspect_bazel_lib expects io_bazel_rules_go and my project expects rules_go

alexeagle added a commit that referenced this issue Dec 6, 2024
io_bazel_rules_go was the old name and retired a while ago.

Fixes #990
@alexeagle
Copy link
Collaborator

alexeagle commented Dec 6, 2024

I believe this is not possible because we still have e2e tests to verify bazel-lib works for WORKSPACE users. See the failures on the attached PR where I tried it.

From https://github.com/bazel-contrib/rules_go/blob/master/docs/go/core/bzlmod.md:

If you have WORKSPACE dependencies that reference rules_go and/or Gazelle, you can still use the legacy repository names for the two repositories:

@fmeum will know for sure.

@fmeum
Copy link
Member

fmeum commented Dec 6, 2024

If your project uses WORKSPACE, pretty much any dependency will expect rules_go's repo to be called io_bazel_rules_go.

If you use Bzlmod, the repo_name that aspect_bazel_lib uses internally shouldn't matter.

What is the error you are seeing?

@alexeagle
Copy link
Collaborator

Error is ERROR: no such package '@@io_bazel_rules_go//go': The repository '@@io_bazel_rules_go' could not be resolved: Repository '@@io_bazel_rules_go' is not defined
https://github.com/bazel-contrib/bazel-lib/actions/runs/12202661633/job/34043875001

Which is expected because we test that bazel-lib works with --noenable_bzlmod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants