fix: remove need for rules_go when depending on a bzl_library target #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
force-pushed
the
test-fixes
branch
4 times, most recently
from
ddb0c94 to
b4e7efa
Compare
kormide
changed the title
thesayyn
approved these changes
Nov 16, 2023
kormide
added a commit
to kormide/bazel-lib
that referenced
this pull request
Nov 16, 2023
kormide
added a commit
that referenced
this pull request
Nov 16, 2023
alexeagle
pushed a commit
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream rulesets that depending on a bzl_library target under
//toolsneeded to bring in rules_go as a dependency because a starlark file loaded in that package (release.bzl) loads from rules_go. Move some files around to remove this dep. Rules_go is a dev_dependency and shouldn't be required by downstream users.Type of change
Test plan