fix: moving the preserve mtiem test logic to Go for portability #907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original bash version of the preserve mtime test doesn't work for Mac / Windows. For better portability I changed this to a
go_test
.Changes are visible to end-users: no
Test plan
I've run this locally on a Linux machine to verify the basic functionality and ensured the test still fails if the
preserve_mtime
attributes are commented out. CI will be needed to test this on Mac / Windows.