refactor: decouple github auth from api calls #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
force-pushed
the
decouple-github-auth
branch
from
2ff4e8c to
3d10141
Compare
kormide
force-pushed
the
decouple-github-auth
branch
from
3d10141 to
b57f7b9
Compare
cgrindel
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefactor for #120.
I had an awkward coupling between how the github client (octokit) is authorized and the api calls it can make, when really they should be separate. There are several different ways we need to authorize: as one of the two GitHub apps, as an installation of those apps on the ruleset repo, bcr fork, and canonical bcr. This decoupling will help me fix #120 in a clean way.