Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/issue-416-fsharp-debug-release-defines #420

Merged
merged 3 commits into from
Mar 14, 2024
Merged

bugfix/issue-416-fsharp-debug-release-defines #420

merged 3 commits into from
Mar 14, 2024

Conversation

njlr
Copy link
Contributor

@njlr njlr commented Mar 1, 2024

Fix DEBUG and RELEASE defines in fsharp_binary.

The issue is that --define can only set one symbol at a time.

To see the fix working, run these in the examples workspace:

bazel run //basic_fsharp:release_mode
bazel run --compilation_mode=dbg //basic_fsharp:release_mode

Closes #416

@njlr njlr requested a review from purkhusid as a code owner March 1, 2024 23:08
@njlr
Copy link
Contributor Author

njlr commented Mar 14, 2024

@purkhusid Please can I have a review? Should be a quick one. Thanks!

@purkhusid
Copy link
Collaborator

@njlr Do you know if the same issue is on the C# side?

@purkhusid
Copy link
Collaborator

Seems like there is some flakyness going on in the Bazel CI.

@purkhusid purkhusid merged commit 862c7f5 into bazel-contrib:master Mar 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purkhusid purkhusid purkhusid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should --compilation_mode=dbg set the DEBUG define?
2 participants
@njlr @purkhusid