Skip to content

Commit

Permalink
respond to fmeum comments
Browse files Browse the repository at this point in the history
  • Loading branch information
matloob committed Dec 13, 2022
1 parent a72b07e commit 6d6b607
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion go/private/rules/sdk.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ go_sdk = rule(
),
"boringcrypto": attr.bool(
mandatory = False,
doc = "The host architecture the SDK was built for",
doc = "Whether the toolchain should be built with boringcrypto cupport enabled",
),
"root_file": attr.label(
mandatory = True,
Expand Down
1 change: 0 additions & 1 deletion go/private/sdk.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,6 @@ def _detect_sdk_version(ctx, goroot):
# Read the third word, or the fourth word if the third word is "devel", to
# find the version number.
output_parts = result.stdout.split(" ")
print("len(output_parts)", len(output_parts), output_parts[2].startswith("go"))
if len(output_parts) > 2 and output_parts[2].startswith("go"):
version = output_parts[2][len("go"):]
elif len(output_parts) > 3 and output_parts[2] == "devel" and output_parts[3].startswith("go"):
Expand Down

0 comments on commit 6d6b607

Please sign in to comment.