Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reproducibility_test hardcodes the "host" output dir #2967

Closed
katre opened this issue Sep 27, 2021 · 4 comments · Fixed by #3026
Closed

reproducibility_test hardcodes the "host" output dir #2967

katre opened this issue Sep 27, 2021 · 4 comments · Fixed by #3026

Comments

@katre
Copy link
Contributor

katre commented Sep 27, 2021

Testing rules_go against bazelbuild/bazel#14049 (which enables the toolchain transition globally), there is a failure in reproducibility_test (https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/ee4684ae-24f9-48bc-b094-0fa33588180e/tests/integration/reproducibility/reproducibility_test/attempt_1.log):

    reproducibility_test.go:226: open /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/2d3ef5fd1c1b57796f35d5cea92c0a3f/bazel_testing/bazel_go_test/main0/bazel-out/host/bin/external/go_sdk/builder: no such file or directory
FAIL

The cause of the error seems to be the hard-coded "host" in the output path. When this change reaches Bazel head, the test will begin failing until this can be fixed.
@katre katre mentioned this issue Sep 27, 2021
Closed
@katre katre mentioned this issue Dec 6, 2021
Closed
@robfig
Copy link
Contributor

robfig commented Dec 7, 2021

Thanks for the heads up.

It seems that output paths are no longer predictable. Is there a recommendation for how to access the build artifact?

@meteorcloudy
Copy link
Contributor

Does $workspace_root/bazel-bin/external/go_sdk/builder work?

@katre
Copy link
Contributor Author

katre commented Dec 7, 2021

You can save the build event messages and check them: https://docs.bazel.build/versions/main/build-event-protocol.html

robfig added a commit that referenced this issue Dec 8, 2021
@robfig
reproducibility_test: explicitly build the go_sdk builder
5e32fb9 
This allows us to find it at a known path.

It is no longer possible to access genfiles at a known path:
bazelbuild/bazel#14049

Fixes #2967
Fixes #3024
@robfig robfig mentioned this issue Dec 8, 2021
Merged
robfig added a commit that referenced this issue Dec 8, 2021
@robfig
reproducibility_test: explicitly build the go_sdk builder (#3026)
b851b94 
This allows us to find it at a known path.

It is no longer possible to access genfiles at a known path:
bazelbuild/bazel#14049

Fixes #2967
Fixes #3024
@robfig
Copy link
Contributor

robfig commented Dec 10, 2021

Confirmed working https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2277#9ff111ee-6b1b-4494-af4e-1e7260ecbe61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reproducibility_test: explicitly build the go_sdk builder bazel-contrib/rules_go
3 participants
@katre @robfig @meteorcloudy