Add bzl_library targets for Stardoc compatibility #2620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as `@io_bazel_rules_go//proto:proto_lib` as a dependency of `@io_bazel_rules_go//go:go_lib`. This is needed to generate Stardoc documentation for rule sets that themselves depend on `rules_go`.
|
I'd prefer to go with #2621 instead of this PR. It's important that these targets follow conventions and can be maintained automatically. |
Yes, that makes sense. Thank you for looking into it so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Adds
bzl_librarytargets for//go:go_liband//proto:proto_lib. The latter is a dependency of//go:go_lib.These targets are required to generate Stardoc documentation for rule sets that themselves depend on
rules_go.Which issues(s) does this PR fix?
Fixes #2619