Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rules_cc to 7bd0e49cfb2237086df89dca9e6ba7a5a5dfb36d #2712

Closed
wants to merge 1 commit into from

Conversation

achew22
Copy link
Member

@achew22 achew22 commented Nov 10, 2020

This is a part of bazel-contrib/bazel-gazelle#760.

To update the copy in the bazel mirror:

cd $(mktemp -d)
wget https://github.com/bazelbuild/rules_cc/archive/7bd0e49cfb2237086df89dca9e6ba7a5a5dfb36d.zip
gsutil cp 02becfef8bc97bda4f9bb64e153f1b0671aec4ba.zip gs://mirror.bazel.build/github.com/bazelbuild/rules_cc/archive/02becfef8bc97bda4f9bb64e153f1b0671aec4ba.zip

Fixed: #2711

This is a part of bazel-contrib/bazel-gazelle#760.

To update the copy in the bazel mirror:

```
cd $(mktemp -d)
wget https://github.com/bazelbuild/rules_cc/archive/7bd0e49cfb2237086df89dca9e6ba7a5a5dfb36d.zip
gsutil cp 02becfef8bc97bda4f9bb64e153f1b0671aec4ba.zip gs://mirror.bazel.build/github.com/bazelbuild/rules_cc/archive/02becfef8bc97bda4f9bb64e153f1b0671aec4ba.zip
```

Fixed: bazel-contrib#2711
@achew22 achew22 requested a review from jayconrod as a code owner November 10, 2020 17:03
@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@achew22
Copy link
Member Author

achew22 commented Nov 10, 2020

Interestingly, it looks like the test is failing because of a minimum version issue. The missing keyword is flagged by incompatible_use_toolchain_transition which appeared in 3.4 I know you don't bump minimum versions lightly, so I wanted to just point this out and see what you thought.

@jayconrod
Copy link
Contributor

Is it important that this update happens now? I'll update everything for the v0.25 release next month, and it's really much easier to update everything together. Gazelle should only use release versions, and I won't be able to backport this to a patch release.

@achew22
Copy link
Member Author

achew22 commented Nov 11, 2020

Is it important that this update happens now?

Sorry to make that unclear. It's totally okay to hold off on this. I was merely trying to

  1. Get an item in the release TODO list
  2. Make that item a single clock away for you

No rush. Thanks for being so prompt and wonderful 🙂

@jayconrod
Copy link
Contributor

Cool, will hold off for now then. Thanks for working through this and for being patient. I know multi-stage changes over a long time are hard to deal with.

@UebelAndre
Copy link

With v0.25 out does that mean the cc rules were updated?

@jayconrod
Copy link
Contributor

@UebelAndre Yes. I'll close this PR since it's superseded by #2742.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rules_cc to
3 participants