Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for building with boringcrypto #3393

Closed
wants to merge 3 commits into from

Conversation

matloob
Copy link
Contributor

@matloob matloob commented Dec 13, 2022

Adds an option to go_register_toolchains and the various go_*_sdk functions to specify boringcrypto = True. Doing so builds the standard library and all library/binary packages using the GOEXPERIMENT=boringcrypto environment variable setting, which switches out the crypto implementation for boringcrypto on Go 1.19+.

What type of PR is this?

Feature

What does this PR do? Why is it needed?

It adds support for building with boringcrypto, which was added in Go 1.19.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Adds an option to go_register_toolchains and the various go_*_sdk
functions to specify boringcrypto = True. Doing so builds the
standard library and all library/binary packages using the
GOEXPERIMENT=boringcrypto environment variable setting, which switches
out the crypto implementation for boringcrypto on Go 1.19+.
@matloob matloob changed the title Boringcrypto2 add support for building with boringcrypto Dec 13, 2022
@matloob
Copy link
Contributor Author

matloob commented Dec 14, 2022

Abandoned in favor of #3398.

@matloob matloob closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant