Support Go 1.24's wasip1 reactors #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmeum would you be able to review this PR? |
Go 1.24 added support for `GOOS=wasip1 GOARCH=wasm go build -buildmode=c-shared`; however, the rules_go starlark code contained validation against this. I also suppressed the addition of a `lib` prefix and the `.so` suffix for wasi reactors. Fixes bazel-contrib#4200 Signed-off-by: Matt Leon <[email protected]>
fmeum
approved these changes
Dec 24, 2024
|
Thanks! We can add a test after Go 1.24 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Go 1.24 added support for
GOOS=wasip1 GOARCH=wasm go build -buildmode=c-shared; however, the rules_go starlark code contained validation against this..wasmsuffix for wasi reactors built with-buildmode=c-sharedWhich issues(s) does this PR fix?
Fixes #4200
Other notes for review
It looks like this could use a test (as simple as adding a new go file under
tests/core/c_linkmodes/); however, the support for features added in this PR requires Go 1.24, which is not out yet. Updatinggo_register_toolchains(version = "1.24rc1")does allow it to build, but thennogofails due to lack of support in some of the linters for go 1.24.