fix: Make context.mode always be GoConfigInfo #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Dec 24, 2024
|
@fmeum I think this needs help to merge |
|
I added a reproducer in #4206 and then applied the fix. The history of CI checks leads me to believe that this is a genuine failure caused by this change, I just don't know why... |
Hmm your repro looks pretty similar to what I tried, I wonder why I didn't have success. Sadly I don't have a laptop with me to try it right now, but it seems good. Let's ship it! |
|
We unfortunately can't ship since the fix legitimately breaks existing tests. I'll look into it. |
peng3141
added a commit
to peng3141/rules_go
that referenced
this pull request
Jan 3, 2025
peng3141
added a commit
to peng3141/rules_go
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Providers and structs with the same fields don't compare equal
Which issues(s) does this PR fix?
Fixes #4197
I wasn't able to figure out a repro in rules_go, it seems like it may rely on some transitions? Not sure we should block landing on this, it seems like this should be the right fix