Get go_bazel_tests to pass with Bzlmod
#4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
bzlmod-go_bazel_test
branch
from
f4664f5 to
7a24891
Compare
linzhp
reviewed
Jan 10, 2025
Co-authored-by: Zhongpeng Lin <[email protected]>
linzhp
approved these changes
Jan 10, 2025
|
FYI I think using a squashed merge would keep the main branch relatively cleaner and easier to review. |
|
Sorry, I thought I had disabled everything but squash merge after moving to contrib. I did that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
go_bazel_testnow works with--enable_bzlmod(tested manually with rules_go and gazelle).Which issues(s) does this PR fix?
Fixes #
Other notes for review