Perform proper string concatenation in jsonnet_to_json() #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like #182 introduced a small regression, where '%' was used instead of '+' to perform string concatenation. This went by unnoticed, because we seemingly don't have any testing coverage for plain jsonnet_to_json(). Solve this by duplicating one of the import tests that was affected by this to invoke plain jsonnet_to_json().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like #182 introduced a small regression, where '%' was used instead of '+' to perform string concatenation. This went by unnoticed, because we seemingly don't have any testing coverage for plain jsonnet_to_json().
Solve this by duplicating one of the import tests that was affected by this to invoke plain jsonnet_to_json().