-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a deps and a setup macro #481
Conversation
It looks like the We should still have the scaffolding, maybe we could use this PR to build Hasher and MergeJars from source, instead of relying on a deploy jar? |
I don’t see any harm in using those rules, but building from source would be good. Want me to do that in a follow up PR?
I think we’ll need to have the maven_install in the repositories file.
…Sent from my iPhone
On 14 Nov 2020, at 08:16, Jin ***@***.***> wrote:
It looks like the @rules_java load requirement is put on hold: bazelbuild/bazel#8746 (comment)
We should still have the scaffolding, maybe we could use this PR to build Hasher and MergeJars from source, instead of relying on a deploy jar?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I'd prefer to add a We can add the scaffolding for deps and setup in this PR, and follow up with a PR to build those binaries from source. |
Discussion about |
This allows us to pull in dependencies that we may need to ensure that rules_jvm_external functions. At present, we use this to make sure we use `rules_java` for our own java targets.
This allows us to pull in dependencies that we may need to ensure that
rules_jvm_external functions. At present, we use this to make sure we
use
rules_java
for our own java targets.