Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle peerDependencies a bit better. #1162

Closed
bweston92 opened this issue Sep 20, 2019 · 1 comment
Closed

Handle peerDependencies a bit better. #1162

bweston92 opened this issue Sep 20, 2019 · 1 comment

Comments

@bweston92
Copy link
Contributor

🚀 feature request

Relevant Rules

  • yarn_install
  • npm_install

Description

Currently creating a React without using TypeScript will require adding many peer dependencies that React has for TypeScript even though it is not used at all however Bazel will fail the install.

Describe the solution you'd like

Either have some sort of ignoreDepedencies in package.json which are read and will no longer fail, this will mean you've acknowledged and are ok with these dependencies being ignored.

Or we can just not hard fail at all on peer dependencies assuming the developer knows best.

Describe alternatives you've considered

You have to add peer dependencies of all packages and sub packages that have them as dependencies in your own package.json
@bweston92 bweston92 mentioned this issue Sep 20, 2019
Merged
5 tasks
This was referenced Sep 24, 2019
Closed
Closed
TinyMan added a commit to TinyMan/rules_nodejs that referenced this issue Sep 30, 2019
@TinyMan
feat(builtin): add flag peer_deps_handling to npm_install / yarn_install
92e7445 
Default to 'strict' (old behavior). Set to 'ignore' to ignore
unmet peer dependencies error.

Closes bazel-contrib#1162
@TinyMan TinyMan mentioned this issue Oct 1, 2019
Closed
12 tasks
@filipesilva filipesilva mentioned this issue Oct 2, 2019
Closed
@alexeagle
Copy link
Collaborator

Latest release no longer errors when peerDeps are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(builtin): add flag peer_deps_handling to npm_install / yarn_install TinyMan/rules_nodejs
2 participants
@alexeagle @bweston92