Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_disable_starlark_host_transitions will break rules_nodejs in Bazel 7.0 #3613

Closed
keertk opened this issue Dec 16, 2022 · 7 comments
Labels
Can Close? We will close this in 30 days if there is no further activity

Comments

@keertk
Copy link

keertk commented Dec 16, 2022

Incompatible flag --incompatible_disable_starlark_host_transitions will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_nodejs. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#17032.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Jun 17, 2023
@sgowroji
Copy link

Hi Team, Gentle ping , Can you share any significant update on this issue. Thanks!

@github-actions github-actions bot removed the Can Close? We will close this in 30 days if there is no further activity label Jun 20, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs in 30 days. Note as of rules_nodejs v6 the rules_nodejs repository contains only the core nodejs toolchain and @bazel/runfiles package. All rulesets are removed and unmaintained. For alternate rulesets suggestions include https://github.com/aspect-build/rules_js, https://github.com/aspect-build/rules_ts Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Aug 20, 2023
@sgowroji
Copy link

This is not yet fixed. Please update!

@alexeagle
Copy link
Collaborator

alexeagle commented Aug 21, 2023

I tried turning this flag on, but it looks like the latest stardoc release depends on a broken rules_license:

ERROR: Traceback (most recent call last):
        File "/private/var/tmp/_bazel_alexeagle/f366b2ea298a1eb16435a50617f648a1/external/rules_license/rules/license.bzl", line 51, column 41, in <toplevel>
                "license_kinds": attr.label_list(
Error in label_list: 'cfg = "host"' is deprecated and should no longer be used. Please use 'cfg = "exec"' instead.
ERROR: /private/var/tmp/_bazel_alexeagle/f366b2ea298a1eb16435a50617f648a1/external/io_bazel_stardoc/stardoc/BUILD:67:6: every rule of type alias implicitly depends upon the target '@io_bazel_stardoc//:license', but this target could not be found because of: error loading package '@io_bazel_stardoc//': initialization of module 'rules/license.bzl' failed

@github-actions github-actions bot removed the Can Close? We will close this in 30 days if there is no further activity label Aug 22, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs in 30 days. Note as of rules_nodejs v6 the rules_nodejs repository contains only the core nodejs toolchain and @bazel/runfiles package. All rulesets are removed and unmaintained. For alternate rulesets suggestions include https://github.com/aspect-build/rules_js, https://github.com/aspect-build/rules_ts Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Oct 21, 2023
Copy link

This issue was automatically closed because it went 30 days without any activity since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants