fix(builtin): detect yarn 2+ berry and adjust CLI args #3195
Conversation
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
| # Can't tell from documentation if Yarn Berry has any replacement for the --mutex | ||
| # flag. We'll have to assume it's safe to run concurrently. |
There was a problem hiding this comment.
There is no replacement for it, we fixed the cache so it's atomic.
There was a problem hiding this comment.
Can't tell from documentation if Yarn Berry has any replacement for the --mutex flag.
My observation on this:
There are a lot of knobs being exposed through .yarnrc file https://yarnpkg.com/configuration/yarnrc#enableGlobalCache so long-term it's probably best if we stop exposing each individual flags through the attributes of yarn_install rule.
Instead, we can create a yarnrc_file attribute to raise awareness to folks that they should be passing the config file explicitly to the rule. Underneath implementation, we just merge that with data and retain current behavior.
There was a problem hiding this comment.
That sounds like a good feature to me. However I don't see how to pass the config file path to yarn install - it looks like it's just automatically inferred from its location. Maybe this could be contributed separately. (maybe it already works just by passing .yarnrc.yml to the data of yarn_install and then it's auto-detected?)
There was a problem hiding this comment.
Yup, my understanding is that folks are already passing it through data and yarn auto detects it inside the sandbox.
There was a problem hiding this comment.
yarn classic (v1) has flag called --use-yarnrc to specify the yarnrc location.
yarn berry searches for the rc file automatically and does not have this flag, but you could change the filename of the rc file to search for by setting the environment variable YARN_RC_FILENAME
| # Can't tell from documentation if Yarn Berry has any replacement for the --mutex | ||
| # flag. We'll have to assume it's safe to run concurrently. |
There was a problem hiding this comment.
Can't tell from documentation if Yarn Berry has any replacement for the --mutex flag.
My observation on this:
There are a lot of knobs being exposed through .yarnrc file https://yarnpkg.com/configuration/yarnrc#enableGlobalCache so long-term it's probably best if we stop exposing each individual flags through the attributes of yarn_install rule.
Instead, we can create a yarnrc_file attribute to raise awareness to folks that they should be passing the config file explicitly to the rule. Underneath implementation, we just merge that with data and retain current behavior.
Fixes #3071
Fixes #1599