We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#313 removes support for .tar.gz file extensions, but rules_js produces them https://github.com/aspect-build/rules_js/blob/main/js/private/js_image_layer.bzl#L230
.tar.gz
#313 says
Non-tar files never actually worked here
But this test has been passing https://github.com/aspect-build/rules_js/blob/main/e2e/js_image_oci/src/test.yaml#L6 so I think that may be incorrect, and we should just revert #313.
FYI @mattyclarkson as this originated from #302
The text was updated successfully, but these errors were encountered:
My issue was with .tar.xz, so it's likely it recognises .tar.gz as that's what it compresses the layers to anyway.
.tar.xz
Sorry, something went wrong.
Okay thanks, that sounds like the right resolution then, I should have been more conservative in the breaking change.
fix(oci_image): restore tars=foo.tar.gz
c1387cb
Partial revert of #313 which went too far in trimming the allow_files extensions. Fixes #334
alexeagle
thesayyn
Successfully merging a pull request may close this issue.
#313 removes support for
.tar.gz
file extensions, but rules_js produces themhttps://github.com/aspect-build/rules_js/blob/main/js/private/js_image_layer.bzl#L230
#313 says
But this test has been passing https://github.com/aspect-build/rules_js/blob/main/e2e/js_image_oci/src/test.yaml#L6 so I think that may be incorrect, and we should just revert #313.
FYI @mattyclarkson as this originated from #302
The text was updated successfully, but these errors were encountered: