Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 release is breaking js_image_layer #334

Closed
alexeagle opened this issue Aug 17, 2023 · 2 comments · Fixed by #335
Closed

1.3.0 release is breaking js_image_layer #334

alexeagle opened this issue Aug 17, 2023 · 2 comments · Fixed by #335
Assignees
Labels
bug Something isn't working prioritized Similar to P1

Comments

@alexeagle
Copy link
Collaborator

#313 removes support for .tar.gz file extensions, but rules_js produces them
https://github.com/aspect-build/rules_js/blob/main/js/private/js_image_layer.bzl#L230

#313 says

Non-tar files never actually worked here

But this test has been passing https://github.com/aspect-build/rules_js/blob/main/e2e/js_image_oci/src/test.yaml#L6 so I think that may be incorrect, and we should just revert #313.

FYI @mattyclarkson as this originated from #302

@alexeagle alexeagle added bug Something isn't working prioritized Similar to P1 labels Aug 17, 2023
@mattyclarkson
Copy link

My issue was with .tar.xz, so it's likely it recognises .tar.gz as that's what it compresses the layers to anyway.

@alexeagle
Copy link
Collaborator Author

Okay thanks, that sounds like the right resolution then, I should have been more conservative in the breaking change.

alexeagle added a commit that referenced this issue Aug 17, 2023
Partial revert of #313 which went too far in trimming the allow_files extensions.

Fixes #334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prioritized Similar to P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants