Revert "refactor: merge repository into repotags (#169)" #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decided the new API is significantly harder to use, and less intuitive. This reverts commit 85b695c.
thesayyn
approved these changes
May 3, 2023
I am happy to read this, because that was my reaction too. I had to teach my stamping rule a few new tricks to include the registry prefix in front of the tags, but the outcome felt strange. Most people don't think of the whole image name as a "tag," despite the longstanding docker tag command's interface. |
|
Yeah @seh I was trying to upgrade a client to HEAD and my nice stamping stuff got gross, so we questioned whether we made the right call. Any other feedback is welcome too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided the new API is significantly harder to use, and less intuitive.
This reverts commit 85b695c.