fix: add cgr.dev into known www_authenticate schemes #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate Go/Java examples from aspect-build/bazel-examples
thesayyn
changed the title
|
@tstromberg can you also add an oci_pull target fetching from cgr.dev to fetch.bzl and oci/tests/BUILD.bazel so that we ensure it works? |
|
Sounds good, I'll do that! |
|
@tstromberg any luck adding the tests? |
|
I've added the tests, but I'm going to re-propose this PR from a clean fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary on top of #237 for pulling authenticated images from cgr.dev (Chainguard Images). Without this patch, the following error occurs:
Error in fail: Failed to fetch https://cgr.dev/v2/chainguard/static/manifests/latest curl: (22) The requested URL returned error: 401