Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing //oci/tests:test_chainguard_static test on ARM. #263

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix failing //oci/tests:test_chainguard_static test on ARM. #263

merged 1 commit into from
Jun 22, 2023

Conversation

sfc-gh-ptabor
Copy link
Contributor

When executed on M1 mac, the diff was failing, as we were comparing alias pointing to ARM (default local platform) vs. crane fetched hardcoded amd.

40a3355584e3c9359179972071a/sandbox/darwin-sandbox/208/execroot/rules_oci/bazel-out/darwin_arm64-fastbuild/bin/oci/tests/test_chainguard_static-test.sh.runfiles/chainguard_static_linux_arm64/layout/index.json
8c8
<          "digest": "sha256:fbfb8a6a1edd7e4f714a3bfdd5e5446e0c13af472d629714399e0c3354db2619",
---
>          "digest": "sha256:bbb40acafe3392a2ff85fa23f597caad80ced4ec698f1adc7638f4fb806d78b2",
10c10
<             "architecture": "amd64",
---
>             "architecture": "arm64",
FAIL: directories "oci/tests/chainguard_static" and "external/chainguard_static_linux_arm64/layout" differ.

@sfc-gh-ptabor sfc-gh-ptabor force-pushed the 20230613-fix-chainguard-test branch from e2e7f8f to e140b63 Compare June 13, 2023 12:25
thesayyn
thesayyn reviewed Jun 14, 2023
View reviewed changes
oci/tests/BUILD.bazel Outdated Show resolved Hide resolved
@sfc-gh-ptabor
Fix failing //oci/tests:test_chainguard_static test on ARM.
0c15e6c 
When executed on M1 mac, the diff was failing, as we were comparing
alias pointing to ARM (default local platform) vs. crane fetched hardcoded amd.
@sfc-gh-ptabor sfc-gh-ptabor force-pushed the 20230613-fix-chainguard-test branch from e140b63 to 0c15e6c Compare June 22, 2023 18:58
@thesayyn thesayyn merged commit d79412e into bazel-contrib:main Jun 22, 2023
@thesayyn
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ptabor @thesayyn