Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '"' from path in MANIFEST_DIGEST when creating a tar file #278

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

rbielak
Copy link
Contributor

@rbielak rbielak commented Jun 21, 2023

Fix for this issue: #273

New version of "yq" will fail processing a path that includes '"'. This fix removes the extra '"' from the path in MANIFEST_DIGEST in the script template that creates the tarball.

rbielak added 2 commits June 21, 2023 10:35
Remove '"' from the name of the manifest digest when creating a tarball.
Remove '"' from path name for the MANIFEST_DIGEST
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add an e2e test that uses the newer yq to prove that this works, and doesn't regress. If you have time to add that...

@alexeagle alexeagle merged commit 5690d61 into bazel-contrib:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants