Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oci_tarball should support more than 2 repo_tags #300

Merged

Conversation

sfc-gh-ptabor
Copy link
Contributor

Due to usage of 'replace_one' in bash instead of 'replace_all',

the attempts to run bazel run examples/empty_base/tarball (with 3 tags), failed with 'Invalid reference format' error, as the line 2 and 3 kept being separated by 'explicit \n'.

Due to usage of 'replace_one' in bash instead of 'replace_all',

the attempts to run `bazel run examples/empty_base/tarball` (with 3 tags),
failed with 'Invalid reference format' error, as the line 2 and 3 kept being separated by 'explicit \n'.
@sfc-gh-ptabor
Copy link
Contributor Author

@alexeagle - could you, please take a look.

@sfc-gh-ptabor sfc-gh-ptabor changed the title oci_tarball should support more than 2 repo_tags Bugfix: oci_tarball should support more than 2 repo_tags Jul 19, 2023
Copy link
Collaborator

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@thesayyn thesayyn changed the title Bugfix: oci_tarball should support more than 2 repo_tags fix: oci_tarball should support more than 2 repo_tags Jul 21, 2023
@thesayyn thesayyn merged commit 91c8e14 into bazel-contrib:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants