-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal error: module 'crosstool' is needed but has not been provided, and implicit use of module files is disabled #334
Comments
The error goes away with |
So are you saying that we need to have clang module support on if using c++20? Before #280 this wasn't the case and if I back out that commit I can happily compile with c++20 (although layering_check seems broken without this as it fails to find the builtin headers in my project) |
Only if you use |
This can be fixed with |
Otherwise Clang defaults to C++ modules with `-std=c++20`, which breaks `layering_check`. Fixes #334
With `-std=c++20`, Clang defaults to using C++ modules rather than Clang modules, which can result in failures when using `layering_check` and thus `use_module_maps`. Fixes bazel-contrib/toolchains_llvm#334 Closes #22660. PiperOrigin-RevId: 642548168 Change-Id: Ie1dd4c482d716635f7b6c53ffd3c5d84b6aa8cc2
With `-std=c++20`, Clang defaults to using C++ modules rather than Clang modules, which can result in failures when using `layering_check` and thus `use_module_maps`. Fixes bazel-contrib/toolchains_llvm#334 Closes bazelbuild#22660. PiperOrigin-RevId: 642548168 Change-Id: Ie1dd4c482d716635f7b6c53ffd3c5d84b6aa8cc2
…22720) With `-std=c++20`, Clang defaults to using C++ modules rather than Clang modules, which can result in failures when using `layering_check` and thus `use_module_maps`. Fixes bazel-contrib/toolchains_llvm#334 Closes #22660. PiperOrigin-RevId: 642548168 Change-Id: Ie1dd4c482d716635f7b6c53ffd3c5d84b6aa8cc2 Commit 9e913fb Co-authored-by: Fabian Meumertzheim <[email protected]>
I have a Bazel C++ repository where I am using
toolchains_llvm
. On macOS, it builds just fine, but on Ubuntu on WSL, I am getting the following error:Here is the repository. I created a minimal repro case for this issue: https://github.com/davidzchen/bazel-ycm-test
Is there a misconfiguration on my part, and how do I fix this? Please let me know if there are any additional information I should provide to debug this.
The text was updated successfully, but these errors were encountered: